Puppet - test if a package already defined?

Question

I'm writing some puppet modules and have a package defined in two modules hence get the following error:

err: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate definition: Package[gnome-session-fallback] is already defined in file /etc/puppet/modules/vnc4server/manifests/init.pp at line 3; cannot redefine at /etc/puppet/modules/vino/manifests/init.pp:7 on node l

Hence want to ensure that the package has not already been defined but the following does not work:

if ! defined ('gnome-session-fallback') {
    package { 'gnome-session-fallback':
        ensure => installed,
    }
}

Can anyone suggest how to fix this, and on the broader scale, what is the "proper" approach to avoiding clashes such as this in modules?

Please post exactly how this does not work. Do you get an error message, or it just simplz does not do what it is supposed to? Also please include which version of Puppet you are using! — ppeterka
– ppeterka, Commented Mar 7, 2013 at 8:35
Error message posted on the second line above - I am testing if its already defined in another module and the test does not seem to detect this and hence attempts to redefine it and the agent run fails (see err). Version 2.7.11 — Mr Morphe
– Mr Morphe, Commented Mar 7, 2013 at 8:44
Maybe I'm a bit dull today: so you get the error with the if ! defined... script, right? — ppeterka
– ppeterka, Commented Mar 7, 2013 at 8:47
The error is as posted in the original post "Error 400 on SERVER: Duplicate definition: Package" etc because the if ! defined test is not working. — Mr Morphe
– Mr Morphe, Commented Mar 7, 2013 at 11:05

Gergo Erdosi · Accepted Answer · 2013-03-09 23:13:39Z

46

You are missing Package[] inside defined(). The correct way to do it:

if ! defined(Package['gnome-session-fallback']) {
    package { 'gnome-session-fallback':
        ensure => installed,
    }
}

answered Mar 9, 2013 at 23:13

Gergo Erdosi

42.3k21 gold badges123 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

Greg Dubicki Over a year ago

Note that it doesn't work in all cases because defined() is dependent on parse order and there's a bug for it opened for a long time.

aetimmes · Accepted Answer · 2014-06-09 19:34:36Z

14

The cleanest way to do this is to use the ensure_resource function from puppetlabs-stdlib:

ensure_resource('package', 'gnome-session-fallback', {'ensure' => 'present'})

answered Jun 9, 2014 at 19:34

aetimmes

1411 silver badge4 bronze badges

Zaroth Over a year ago

an even cleaner function to do this from said library is ensure_packages(['pkg1', 'pkg2'])

Mr Morphe · Accepted Answer · 2013-06-27 12:07:47Z

5

To answer my own question about what the "proper" approach is : This issue is discussed at https://groups.google.com/forum/?fromgroups=#!topic/puppet-users/julAujaVsVk and jcbollenger offers what looks like a "best-practice" solution - resources which are defined multiple times should be moved into their own module and included into the classes on which they depend. I applied this and solved my problem.

This doesn't actually answer why "if !defined" fails however...

edited Jun 27, 2013 at 12:07

answered Mar 7, 2013 at 13:58

Mr Morphe

6941 gold badge7 silver badges15 bronze badges

Comments

Christopher E. Stith · Accepted Answer · 2016-10-24 18:28:25Z

1

One cleaner way (among multiple ways) is to create a virtual package resource and then realize it. You can realize the same virtual package multiple times without error.

@package { 'gnome-session-fallback':
    ensure => installed,
}

And then where you need it:

realize( Package[ 'gnome-session-fallback' ] )

answered Oct 24, 2016 at 18:28

Christopher E. Stith

814 bronze badges

Collectives™ on Stack Overflow

Puppet - test if a package already defined?

4 Answers 4

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related