feat: add support for tracing of generators using capture_method decorator#113
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #113 +/- ##
===========================================
- Coverage 100.00% 98.71% -1.29%
===========================================
Files 17 17
Lines 499 546 +47
Branches 46 48 +2
===========================================
+ Hits 499 539 +40
- Misses 0 7 +7
Continue to review full report at Codecov.
|
Contributor
Author
|
This solves for the example reported in the issue (generator context managers) as well as plain generator functions, but I'd like to get some more eyes on it to make sure we aren't introducing unwanted side effects.
|
to-mc
changed the title
to-mc
commented
Aug 18, 2020
to-mc
commented
Aug 18, 2020
heitorlessa
suggested changes
Aug 18, 2020
heitorlessa
approved these changes
Aug 19, 2020
heitorlessa
left a comment
heitorlessa
left a comment
Contributor
There was a problem hiding this comment.
Changes look great, and docs are clear to me :)
Thanks a lot Tom for pulling this together.
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Aug 22, 2020
* develop: chore: version bump to 1.3.1 fix(capture_method): should yield inside with (#124) chore: bump version to 1.3.0 (#122) chore(deps): bump prismjs from 1.20.0 to 1.21.0 in /docs chore(deps): bump elliptic from 6.5.2 to 6.5.3 in /docs feat: add parameter utility (#96) chore: bump version to 1.2.0 (#119) feat: add support for tracing of generators using capture_method decorator (#113)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #112
Description of changes:
Added checks to capture_method to test if decorated function is a generator (and/or a context manager) and handle those cases appropriately.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.