fix(ci): add auth to API HTTP Gateway and Lambda Function Url#1882
Merged
Conversation
boring-cyborg
Bot
added
dependencies
pull-request-size
Bot
added
the
size/M
rubenfonseca
requested review from
heitorlessa
and removed request for
a team
2 tasks
Contributor
|
Looking... |
heitorlessa
suggested changes
Feb 1, 2023
heitorlessa
left a comment
heitorlessa
left a comment
Contributor
There was a problem hiding this comment.
Looks great!! One comment on maintenance (keyword-argument), and one on UX for a better function name for the future reader.
Contributor
Author
|
@heitorlessa feedback addressed |
heitorlessa
approved these changes
Feb 1, 2023
Contributor
|
another awesome work, thank you @rubenfonseca 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #1877
Summary
Changes
This PR adds the aws-requests-auth library and uses it to authenticate requests to API Gateway HTTP, and
Lambda Functions urls during e2e testing.
User experience
Before this change E2E could fail for internal compliance reasons.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.