chore(ci): replace deprecated set-output commands#1957
Merged
Conversation
boring-cyborg
Bot
added
the
github-actions
pull-request-size
Bot
added
the
size/S
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
cibinmathew
changed the title
cibinmathew
changed the title
cibinmathew
changed the title
Contributor
|
This is awesome, thank you for taking the time! I’ll review it as soon as I
can tomorrow ;)
…On Mon, 27 Feb 2023 at 09:08, Cibin Mathew ***@***.***> wrote:
@cibinmathew <https://github.com/cibinmathew> requested review from
@awslabs/aws-lambda-powertools-python on: #1957
<#1957> ci:
replace deprecated set-output commands as a code owner.
—
Reply to this email directly, view it on GitHub
<#1957 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBA6WBVDLZSL7VDJ2IDWZROIXANCNFSM6AAAAAAVIXLKVY>
.
You are receiving this because your review was requested.Message ID:
<awslabs/aws-lambda-powertools-python/pull/1957/issue_event/8612768321@
github.com>
|
heitorlessa
requested review from
heitorlessa
and removed request for
rubenfonseca
Contributor
|
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
github-actions
Bot
added
do-not-merge
need-issue
heitorlessa
approved these changes
Feb 28, 2023
heitorlessa
changed the title
Contributor
|
Looks great, merging. Thanks a lot for taking the time @cibinmathew - these are quality of life governance improvements that we appreciate very much. |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #1591
Summary
Replace deprecated
save-stateandset-outputcommands to the new format: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameterChanges
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.