fix(typing): swap NoReturn with None for methods with no return value

[tibbe]

Issue number: #2002

Summary

NoReturn are for methods that never return (e.g. always raise exceptions). Using NoReturn causes e.g. mypy to think all code following the call to the NoReturn method to be unreachable.

Changes

The

• put_annotation
• put_metadata
• patch
• patch_all

methods of BaseSegment now have the correct return type for methods that return not (but do in fact return).

User experience

Before this change using any of the above methods would lead to type errors/unreachable code errors when used with e.g. mypy.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[boring-cyborg]

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

[rubenfonseca]

@tibbe thank you so much for reporting and fixing this so quickly! We really appreciate this, and we will release this to the public later this week

[boring-cyborg]

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!