feat: Add Kinesis lambda event support to Parser utility#227
Conversation
heitorlessa
left a comment
There was a problem hiding this comment.
Awesome, looks clean enough and specially the pre-validation piece :)
One additional ask as with other PRs:
- Could you please update the model and envelope docs?
heitorlessa
left a comment
There was a problem hiding this comment.
Adding additional comments to commit later on renaming Kinesis with KinesisDataStream to allow expansion with other products
|
thanks a lot as always @risenberg-cyberark - As discussed, I'll commit these suggestions, and will try pushing the docs to your branch then merge. Failing that, I'll merge as-is, then send another PR with docs and suggestions implemented ;) ETA: This Friday EOD |
Codecov Report
@@ Coverage Diff @@
## develop #227 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 70 72 +2
Lines 2600 2649 +49
Branches 109 110 +1
========================================
+ Hits 2597 2646 +49
Misses 3 3
Continue to review full report at Codecov.
|
* develop: docs: add S3 as a supported model docs: add CW Logs as a supported envelope fix: cloudwatch logs envelope typo docs: add CW Logs as a supported model docs: add Alb as a supported model docs: shadow sidebar to remain expanded cr fixes feat: Add cloudwatch lambda event support to Parser utility feat: Add alb lambda event support to Parser utility #228 feat: Add S3 lambda event support to Parser utility #224
heitorlessa
left a comment
There was a problem hiding this comment.
Docs added - Merging
feat: Add Kinesis lambda event support to Parser utility #226
This adds automatic base64 decode in the schema.