fix(event_source): change the import location of boto3 in CodePipelineJobEvent data class#2353
Merged
leandrodamascena merged 3 commits intoJun 1, 2023
Merged
fix(event_source): change the import location of boto3 in CodePipelineJobEvent data class#2353leandrodamascena merged 3 commits into
leandrodamascena merged 3 commits into
Conversation
pull-request-size
Bot
added
the
size/XS
darnley
changed the title
boto3 import locationboto3 import location incode_pipeline_job_event
Contributor
Author
|
Hey @leandrodamascena! |
darnley
changed the title
boto3 import location incode_pipeline_job_eventboto3 import location incode_pipeline_job_event
leandrodamascena
changed the title
boto3 import location incode_pipeline_job_event
boring-cyborg
Bot
added
the
documentation
pull-request-size
Bot
added
size/S
Contributor
Hi @darnley! Yes, we don't need to do anything else you've already done. I just pushed a commit with minor changes because we merged a PR before that and had a conflict. Thank you so much for sending this PR at lightning speed. 🚀 |
leandrodamascena
requested review from
leandrodamascena
and removed request for
rubenfonseca
roger-zhangg
pushed a commit
to roger-zhangg/aws-lambda-powertools-python
that referenced
this pull request
Jun 5, 2023
…eJobEvent data class (aws-powertools#2353) Co-authored-by: Leandro Damascena <leandro.damascena@gmail.com>
sthulb
pushed a commit
that referenced
this pull request
Jun 19, 2023
…eJobEvent data class (#2353) Co-authored-by: Leandro Damascena <leandro.damascena@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #2352
Summary
Importing
boto3at top level incode_pipeline_job_event.pyis affecting performance when import modules that needsaws_lambda_powertools.utilities.data_classes.Changes
Change the import location of
boto3incode_pipeline_job_event.pyto be within functionsetup_s3_clientinstead of top level, since this is being used to download an artifact from CodePipeline Job and it is not a common use.User experience
Decrease of import time when importing modules that uses
aws_lambda_powertools.utilities.data_classes, such asApiGatewayResolver.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.