feat: support custom formats in JSON Schema validation#247
Merged
Conversation
added 2 commits
December 17, 2020 19:16
heitorlessa
suggested changes
Dec 21, 2020
Contributor
Author
|
Test added. |
heitorlessa
changed the title
heitorlessa
changed the title
heitorlessa
approved these changes
Jan 11, 2021
heitorlessa
left a comment
heitorlessa
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution @n2N8Z ! I've made the following changes to your fork in order to merge it safely:
- Make function args non-mutable
- Additional test covering invalid custom formats
- Exception capturing ordering and invalid schema defintion exception to cover invalid formats
- Docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Issue #246
Description of changes:
Pass formats dict through to fastjsonschema
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.