refactor(event_source): centralizing helper functions for query, header and base64#2496
Merged
leandrodamascena merged 4 commits intoJun 20, 2023
Merged
refactor(event_source): centralizing helper functions for query, header and base64#2496leandrodamascena merged 4 commits into
leandrodamascena merged 4 commits into
Conversation
heitorlessa
reviewed
Jun 19, 2023
heitorlessa
reviewed
Jun 19, 2023
heitorlessa
reviewed
Jun 19, 2023
heitorlessa
reviewed
Jun 19, 2023
Contributor
|
LGTM after you refactor to use kwargs over args in for |
Contributor
|
Good to go.... still don't have my access fixed :/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2496 +/- ##
===========================================
- Coverage 97.15% 97.12% -0.03%
===========================================
Files 157 158 +1
Lines 7345 7346 +1
Branches 533 517 -16
===========================================
- Hits 7136 7135 -1
Misses 160 160
- Partials 49 51 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leandrodamascena
changed the title
leandrodamascena
changed the title
leandrodamascena
changed the title
github-actions
Bot
added
bug
heitorlessa
approved these changes
Jun 20, 2023
2 tasks
heitorlessa
changed the title
pull-request-size
Bot
added
the
size/L
rafaelgsr
pushed a commit
to rafaelgsr/aws-lambda-powertools-python
that referenced
this pull request
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #2424
Summary
Changes
This PR unifies all the helper functions in one file to avoid drifts and fix minor problems in event source data classes.
User experience
There is no change in the user experience.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.