feat: support extra parameter in Logger messages#257
Merged
heitorlessa merged 4 commits intoJan 12, 2021
Conversation
* develop: chore: general simplifications and cleanup (#255)
Contributor
Author
|
customer approvals: #253 (comment) |
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Jan 17, 2021
* develop: chore: move env names to constant file (#264) docs: fix import (#267) feat: Add AppConfig parameter provider (#236) chore: update stale bot improv: override Tracer auto-capture response/exception via env vars (#259) docs: add info about extras layer (#260) feat: support extra parameter in Logger messages (#257) chore: general simplifications and cleanup (#255)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #253
Description of changes:
This PR adds support for extra parameter when logging messages across all levels. Any key/value added using
extraparameter will be at the root level of the structured log.Before this PR, all fields added in
extraparameter are discarded when structuring logs.UX
Add request_id field while logging a message
{ "level": "INFO", "location": "<module>:5", "message": "Hello", "timestamp": "2021-01-12 14:08:12,357", "service": "payment", "sampling_rate": 0.0, "request_id": "1123" }FAQ
Q: What's the difference between
structure_logandextraafter this PR?Keys added with
structure_logwill persist across multiple log messages while keys added viaextrawill only be available in a given log message operation.Example - Persisting payment_id not request_id
Note that
payment_idremains in both log messages whilebooking_idis only available in the first message.{ "level": "INFO", "location": "<module>:5", "message": "Flight booked successfully", "timestamp": "2021-01-12 14:09:10,859", "service": "payment", "sampling_rate": 0.0, "payment_id": "123456789", "booking_id": "75edbad0-0857-4fc9-b547-6180e2f7959b" }, { "level": "INFO", "location": "<module>:6", "message": "goodbye", "timestamp": "2021-01-12 14:09:10,860", "service": "payment", "sampling_rate": 0.0, "payment_id": "123456789" }Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.