feat(parser): add support to VpcLatticeModel#2584
Merged
rubenfonseca merged 5 commits intoJun 27, 2023
Merged
Conversation
2 tasks
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #2584 +/- ##
========================================
Coverage 97.21% 97.22%
========================================
Files 158 160 +2
Lines 7370 7394 +24
Branches 537 537
========================================
+ Hits 7165 7189 +24
Misses 158 158
Partials 47 47
☔ View full report in Codecov by Sentry. |
rubenfonseca
suggested changes
Jun 27, 2023
rubenfonseca
left a comment
Contributor
There was a problem hiding this comment.
Thanks Leandro for the quick turn-around! Just left two small comments. What do you think?
Co-authored-by: Ruben Fonseca <fonseka@gmail.com> Signed-off-by: Leandro Damascena <lcdama@amazon.pt>
Co-authored-by: Ruben Fonseca <fonseka@gmail.com> Signed-off-by: Leandro Damascena <lcdama@amazon.pt>
Contributor
Author
I agree 100%, Ruben! All of them were addressed. |
rafaelgsr
pushed a commit
to rafaelgsr/aws-lambda-powertools-python
that referenced
this pull request
Jun 30, 2023
Co-authored-by: Ruben Fonseca <rubefons@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #2579
Summary
Changes
Use case:
Customers can integrate VPC Lattice with Lambda and might need to parser events using Pydantic.
Changes:
This pull request introduces support to the VPCLatticeModel and envelope.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.