Skip to content

chore(ci): use sast on every commit on any supported language#2646

Merged
leandrodamascena merged 1 commit into
aws-powertools:developfrom
heitorlessa:ci/codeql-sast-improvements
Jul 4, 2023
Merged

chore(ci): use sast on every commit on any supported language#2646
leandrodamascena merged 1 commit into
aws-powertools:developfrom
heitorlessa:ci/codeql-sast-improvements

Conversation

@heitorlessa

@heitorlessa heitorlessa commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Issue number: #2203

Summary

OSSF Scorecard scanner doesn't compute event filters so we must run CodeQL on any file. We still don't run on PRs as it takes ~28m to complete, blocking PRs to be merged which never returned anything useful (given the toolset we use)

Alert: https://github.com/aws-powertools/powertools-lambda-python/security/code-scanning/42

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team July 4, 2023 15:44
@boring-cyborg boring-cyborg Bot added the github-actions Pull requests that update Github_actions code label Jul 4, 2023
@pull-request-size pull-request-size Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 4, 2023
@github-actions github-actions Bot added internal Maintenance changes labels Jul 4, 2023
@leandrodamascena leandrodamascena merged commit 39b7034 into aws-powertools:develop Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github-actions Pull requests that update Github_actions code internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants