feat(logger): implement addFilter/removeFilter to address static typing errors#3380
Merged
Merged
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
2 tasks
sthulb
previously approved these changes
Nov 21, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3380 +/- ##
===========================================
- Coverage 95.39% 95.37% -0.02%
===========================================
Files 208 208
Lines 9633 9637 +4
Branches 1766 805 -961
===========================================
+ Hits 9189 9191 +2
- Misses 330 331 +1
- Partials 114 115 +1 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
@sthulb good to go now, ignored Sonar rule in functional test as it doesn't pose any risk (we want to redact sensitive data in our test). One last CI check (Python 3.11) and passing that it's good to merge. tks |
sthulb
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Issue number: #3358
Summary
Adds
addFiltermethod that was previously missing so static type checkers are happy.Changes
addFilterpublic methodremoveFilterpublic methodUnrelated changes
logging._ExcInfoTypeinexception()method as per Static typing: Logger.exception() exc_info type does not match Python's built-in one #3356User experience
Experience in adding a filter like it was before but without any mypy errors
JSON output
{ "level": "INFO", "location": "<module>:18", "message": "Blah", "timestamp": "2023-11-21 09:59:48,477+0100", "service": "service_undefined", "api_key": "REDACTED" }Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.