refactor(feature-flags): add intersection tests; structure refinement#3775
Merged
heitorlessa merged 29 commits intoFeb 19, 2024
Merged
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3775 +/- ##
===========================================
+ Coverage 96.38% 96.39% +0.01%
===========================================
Files 214 214
Lines 10030 10102 +72
Branches 1846 1869 +23
===========================================
+ Hits 9667 9738 +71
- Misses 259 260 +1
Partials 104 104 ☔ View full report in Codecov by Sentry. |
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
2 tasks
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Contributor
Author
|
Leaving these for another two PRs
|
heitorlessa
commented
Feb 19, 2024
heitorlessa
left a comment
Contributor
Author
There was a problem hiding this comment.
had a peer review with @rubenfonseca and will make the following changes before:
- Add debug on
noopmethod - Use
cachedpropertyforTimeValues
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Contributor
Author
|
Leaving to a separate PR
|
rubenfonseca
previously approved these changes
Feb 19, 2024
Co-authored-by: Ruben Fonseca <fonseka@gmail.com> Signed-off-by: Heitor Lessa <lessa@amazon.nl>
|
rubenfonseca
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: #3531
Summary
Adds remaining changes before releasing new intersection rule actions
ANY_IN_VALUE,ALL_IN_VALUE,NONE_IN_VALUE.Changes
ANY_IN_VALUEALL_IN_VALUENONE_IN_VALUEcontext_valueandcondition_valuefn argumentsValueErrorfor non-list context valueANY_IN_VALUEALL_IN_VALUENONE_IN_VALUEUnrelated
lambdaactions on every evaluation call)getattr)User experience
ALL_IN_VALUE
{ "my_feature": { "default": false, "rules": { "tenant_id is in allowed list": { "when_match": true, "conditions": [ { "action": "ALL_IN_VALUE", "key": "tenant_id", "value": [ "Łukasz", "Gerald", "Leandro", "Heitor" ] } ] } } } }ANY_IN_VALUE
{ "my_feature": { "default": false, "rules": { "tenant_id is in allowed list": { "when_match": true, "conditions": [ { "action": "ANY_IN_VALUE", "key": "tenant_id", "value": [ "Łukasz", "Gerald", "Leandro", "Heitor" ] } ] } } } }NONE_IN_VALUE
{ "my_feature": { "default": false, "rules": { "tenant_id is in allowed list": { "when_match": true, "conditions": [ { "action": "NONE_IN_VALUE", "key": "tenant_id", "value": [ "Łukasz", "Gerald", "Leandro", "Heitor" ] } ] } } } }Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.