fix(ci): create one layer artifact per region & merge#3808
Merged
heitorlessa merged 5 commits intoFeb 20, 2024
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
boring-cyborg
Bot
added
the
github-actions
pull-request-size
Bot
added
the
size/S
Contributor
Author
|
We carried out tests on a separate @dreamorosi repo: https://github.com/dreamorosi/actions-playground/blob/c2189e306b4b657b52cc650dec7123cc780cb061/.github/workflows/test.yml#L60 TypeScript related PR: aws-powertools/powertools-lambda-typescript#2095 |
|
dreamorosi
approved these changes
Feb 20, 2024
dreamorosi
left a comment
dreamorosi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for teaming up.
It's been fun!
sthulb
approved these changes
Feb 20, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #3780
Summary
This PR addresses the new racing condition introduced in upload-artifact@v4.
Previously, we were updating every Layer ARN deployment output to the same artifact name. In V4, an explicit overwrite flag is required, which raises on race conditions (good behavior!).
Now, we upload every layer artifact with the region suffix, then merge all artifacts upon download. Everything else remains the same.
Changes
patterninstead ofnamein download-artifact to be able to merge multiple artifactsUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.