feat(event_handler): define exception_handler directly from the router#3979
Merged
leandrodamascena merged 1 commit intoMar 19, 2024
Merged
feat(event_handler): define exception_handler directly from the router#3979leandrodamascena merged 1 commit into
leandrodamascena merged 1 commit into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3979 +/- ##
===========================================
- Coverage 96.38% 96.30% -0.08%
===========================================
Files 214 215 +1
Lines 10030 10262 +232
Branches 1846 1915 +69
===========================================
+ Hits 9667 9883 +216
- Misses 259 271 +12
- Partials 104 108 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Reviewing now |
rubenfonseca
approved these changes
Mar 19, 2024
rubenfonseca
left a comment
Contributor
There was a problem hiding this comment.
Nice and clean, loved it!
|
Cool! @leandrodamascena // @rubenfonseca which release version will this be a part of? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue number: #1193
Summary
Changes
This pull request introduces a new feature allowing the direct definition of an exception_handler from the router. This enhancement is particularly beneficial for customers who are segmenting their routers into multiple files and including them in the Resolver.
User experience
split_route_module.py
app.py
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.