fix(tracer): add name sanitization for X-Ray subsegments#4005
Merged
leandrodamascena merged 5 commits intoMar 22, 2024
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4005 +/- ##
===========================================
- Coverage 96.38% 96.30% -0.08%
===========================================
Files 214 215 +1
Lines 10030 10275 +245
Branches 1846 1913 +67
===========================================
+ Hits 9667 9895 +228
- Misses 259 271 +12
- Partials 104 109 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rubenfonseca
suggested changes
Mar 22, 2024
|
rubenfonseca
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue number: #3981
Summary
Changes
This pull request addresses the concern raised by @loesak regarding subsegment names generated when using our Tracer utility. While there's currently no loss of tracer or subsegment data, it's crucial to ensure that the generated names comply with the X-Ray specification to prevent any potential issues or warnings.
User experience
By implementing name sanitization, we'll ensure that X-Ray no longer emits warnings due to non-compliant subsegment names. This bug fix will result in customers no longer receiving X-Ray warnings.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.