feat(logger): add method to return currently configured keys#4033
Merged
leandrodamascena merged 12 commits intoApr 12, 2024
Merged
feat(logger): add method to return currently configured keys#4033leandrodamascena merged 12 commits into
leandrodamascena merged 12 commits into
Conversation
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #4033 +/- ##
===========================================
- Coverage 96.38% 96.25% -0.13%
===========================================
Files 214 216 +2
Lines 10030 10393 +363
Branches 1846 1927 +81
===========================================
+ Hits 9667 10004 +337
- Misses 259 275 +16
- Partials 104 114 +10 ☔ View full report in Codecov by Sentry. |
2 tasks
gwlester
reviewed
Mar 28, 2024
rubenfonseca
suggested changes
Apr 10, 2024
rubenfonseca
left a comment
Contributor
There was a problem hiding this comment.
Great stuff! Just left two tiny comments
rubenfonseca
suggested changes
Apr 10, 2024
rubenfonseca
left a comment
Contributor
There was a problem hiding this comment.
Waiting for the changes discussed offline
rubenfonseca
suggested changes
Apr 10, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue number: #3505
Summary
Changes
This pull request introduces a new method
current_keysto the Logger utility. The primary objective of this method is to offer a straightforward approach for retrieving the currently configured keys utilized within the logger. Additionally, it serves to prevent mistakes such as overwriting keys.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.