fix(typing): make the case_sensitive field a boolean only#4128
Merged
Conversation
pull-request-size
Bot
added
the
size/M
tonnico
changed the title
rubenfonseca
added
the
typing
rubenfonseca
force-pushed
the
feat/typing
branch
from
c7db9f2 to
c5dd3c2
Compare
|
rubenfonseca
approved these changes
Apr 15, 2024
rubenfonseca
left a comment
rubenfonseca
left a comment
Contributor
There was a problem hiding this comment.
Just waiting for CI to pass
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4128 +/- ##
===========================================
- Coverage 96.38% 96.25% -0.13%
===========================================
Files 214 216 +2
Lines 10030 10393 +363
Branches 1846 1921 +75
===========================================
+ Hits 9667 10004 +337
- Misses 259 275 +16
- Partials 104 114 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rubenfonseca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #4127
Summary
Changes
case_sensitive become bool only.
User experience
It seems to be weird that case_sensitive could be None. It is case_sensitive or not. There is no environment variable where we could have a default value.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.