Skip to content

refactor(metrics): add from __future__ import annotations#4944

Merged
leandrodamascena merged 1 commit into
aws-powertools:v3from
ericbn:metrics_annotations
Aug 15, 2024
Merged

refactor(metrics): add from __future__ import annotations#4944
leandrodamascena merged 1 commit into
aws-powertools:v3from
ericbn:metrics_annotations

Conversation

@ericbn

@ericbn ericbn commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

Issue number: #4953

Summary

Changes

Add from __future__ import annotations to metrics package

User experience

Discussed in #4607

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

and update code according to ruff rules TCH, UP006, UP007, UP037 and
FA100.
@ericbn ericbn requested a review from a team August 13, 2024 01:25
@pull-request-size pull-request-size Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2024
@sonarqubecloud

Copy link
Copy Markdown

@leandrodamascena leandrodamascena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!

@leandrodamascena leandrodamascena merged commit b5d54eb into aws-powertools:v3 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement metrics size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tech debt: add from __future__ import annotations in the Metrics feature

2 participants