refactor(typing): move more types into TYPE_CHECKING#5088
Conversation
|
Looking at the changes done as part of #4607, I double checked that this was the only place where we moved a pydantic import to outside TYPE_CHECKING. I see you already fixed this. I'm just trying to improve on top of your fix. |
|
|
Hi @ericbn! Thanks for opening this PR! I'm planning to review it by Friday. In the meantime, and if possible, can you please test version 3.0.0.dev10? I mean, maybe install it in some Lambda function and run your local tests or development environment? It would be great to get some feedback on this. https://pypi.org/project/aws-lambda-powertools/3.0.0.dev10/ Thanks |
|
@leandrodamascena FYI these are the modules we use in our project:
I've updated our project to use plain aws-lambda-powertools==3.0.0.dev10 installed in our our shared layer, no other extras, nor any AWSLambdaPowertoolsPythonVX layer. Deployed it to a remote dev environment and all working like a charm! |
That's completely amazing to hear @ericbn! Thanks a lot for testing this! ❤️ |
|
Hi @ericbn! Sorry for the delay, but I had to travel for some internal meetings and I'm returning tomorrow and will finish this review this week. Thanks |
leandrodamascena
left a comment
There was a problem hiding this comment.
APPROVED! Thanks @ericbn! 🚀



Issue number: #5029
Summary
Changes
Move more types into TYPE_CHECKING.
User experience
Following up issues reported in #5029.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.