fix(parameters): fix force_fetch feature when working with get_parameters#5515
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5515 +/- ##
========================================
Coverage 96.16% 96.16%
========================================
Files 229 229
Lines 10810 10810
Branches 2007 2007
========================================
Hits 10395 10395
Misses 327 327
Partials 88 88 ☔ View full report in Codecov by Sentry. |
dreamorosi
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: #5482
Summary
Changes
The
force_fetch=Trueoption inget_parameters()was not updating cached values as expected, causing Lambda functions to use outdated parameter values even after updates in SSM.Solution:
get_multiplefunction.force_fetchandraise_on_transform_errorwere inverted, causingforce_fetchvalue to be ignored.**kwargs.User experience
No changes
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.