refactor(data_classes): Add base class with common code#6297
Merged
leandrodamascena merged 2 commits intoMar 19, 2025
Conversation
This uses multiple inheritance, which is overly complex.
7 tasks
2 tasks
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6297 +/- ##
===========================================
- Coverage 96.33% 96.32% -0.01%
===========================================
Files 242 242
Lines 11699 11674 -25
Branches 864 864
===========================================
- Hits 11270 11245 -25
Misses 336 336
Partials 93 93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leandrodamascena
approved these changes
Mar 19, 2025
leandrodamascena
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on another PR @ericbn! APROVADO!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: #6293
Summary
Changes
This uses multiple inheritance, which is overly complex. I personally think is't not worth it, but here it is as an exercise and for us to see how it looks like. Alternatively, we can choose to keep only one of the base classes and repeat the code of the other. Or we can just disregard this altogether, as introducing any inheritance is always debatable in terms of benefit vs. complexity and maintability.
User experience
No user experience change.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.