feat(logger): add support for exception notes#6465
Merged
Conversation
2 tasks
Contributor
Author
|
Hey @anafalcao! Can you please review this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6465 +/- ##
========================================
Coverage 96.32% 96.33%
========================================
Files 243 243
Lines 11824 11826 +2
Branches 881 881
========================================
+ Hits 11390 11392 +2
Misses 338 338
Partials 96 96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
leandrodamascena
added a commit
that referenced
this pull request
Apr 24, 2025
* Adding support for exception notes * Adding support for exception notes * Python... --------- Co-authored-by: Ana Falcão <anafalcao@poli.ufrj.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: #6441
Summary
This PR adds support for exception notes in the logger. When using
logger.exception, any notes attached to exceptions will now be propagated and included in the log line under a newexception_noteskey.Exception notes provide additional context for errors, making debugging easier and logs more informative.
User experience
and the output:
{ "level": "ERROR", "location": "collect.handler:15", "message": "Received a HTTP 5xx error", "timestamp": "2021-05-03 11:47:12,494+0000", "service": "payment", "exception_name": "RuntimeError", "exception": "Traceback (most recent call last):\n File \"<input>\", line 2, in <module> RuntimeError: Unable to fullfil request", "exception_notes":[ "Can't connect to the endpoint" ] }Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.