Skip to content

add fip proposing p256 address types - #321

Closed
whyrusleeping wants to merge 1 commit into
masterfrom
add-p256-keys
Closed

add fip proposing p256 address types#321
whyrusleeping wants to merge 1 commit into
masterfrom
add-p256-keys

Conversation

@whyrusleeping

Copy link
Copy Markdown
Member

I've wanted this for a while, seems like better late than never.

Comment thread FIPS/fip-p256-keys.md
## Abstract
Filecoin ramps should be as simple and available as possible, adding p256 opens up a whole new set of solutions for developers to integrate with.

## Change Motivation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, the iPhone also supports Curve25519 (https://developer.apple.com/documentation/cryptokit/curve25519) and the docs specify that the enclave supports "256bit elliptic curve algorithms". Are you sure it only supports P256?

Unfortunately, it looks like Android may only support RSA and P256.

Maybe we should just add support for both at the same time?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cost of adding two algorithms versus one is pretty minimal.

@whyrusleeping whyrusleeping Mar 15, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the more the merrier, Curve25519 is getting a lot of traction too, and youre right, adding more is easy.

@kaitlin-beegle

Copy link
Copy Markdown
Contributor

Hey @whyrusleeping, would you mind adding this proposal/summary to the FIPs Discussion Forum too, so I can steward it for community feedback?

Thank you!

@kaitlin-beegle

Copy link
Copy Markdown
Contributor

Reached out again to FIP author to determine whether to merge or deprecate this draft.

@kaitlin-beegle

Copy link
Copy Markdown
Contributor

Closing PR, per this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants