fix(loki.process): Wrap template in a custom type and move validation to syntax.Validator#5910
Conversation
kalleep
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3556d81c2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ac9a53c73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… to syntax.Validator (#5910) ### Pull Request Details This pr does two things: 1. Wrap Template in a custom type that implements `encoding.TextMarshaler` and `encoding.TextUnmarshaler`. This allows us to catch invalid templates when config is parsed instead of when building the stage. 2. Implement `syntax.Validator` for `TemplaceConfig`. ### Issue(s) fixed by this Pull Request Part of: #5549 Part of: #5913 ### Notes to the Reviewer <!-- Relevant notes for reviewers/testers. --> ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [x] Tests updated - [x] Config converters updated
2 participants
Pull Request Details
This pr does two things:
encoding.TextMarshalerandencoding.TextUnmarshaler. This allows us to catch invalid templates when config is parsed instead of when building the stage.syntax.ValidatorforTemplaceConfig.Issue(s) fixed by this Pull Request
Part of: #5549
Part of: #5913
Notes to the Reviewer
PR Checklist