Skip to content

Add language and tab editor settings#2406

Merged
ellisonbg merged 3 commits into
jupyterlab:masterfrom
blink1073:fileeditor-settings
Jun 13, 2017
Merged

Add language and tab editor settings#2406
ellisonbg merged 3 commits into
jupyterlab:masterfrom
blink1073:fileeditor-settings

Conversation

@blink1073

@blink1073 blink1073 commented Jun 8, 2017

Copy link
Copy Markdown
Contributor

Partially addresses #2382. Fixes #2351.

@ellisonbg

Copy link
Copy Markdown
Contributor

Great! A few possible changes:

  • Group the items in the Editor menu by whether or not they are per file or global. I would put the per file ones at the top, then a separator, and then the global/settings ones.
  • Maybe only include 1,2,4,8 space indent options?
  • Add the indent options to the Editor command palette.

I did test with a dockerfile and a Makefile and it completely solves the pain point with those file types!

@ellisonbg ellisonbg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above post on changes requested.

@blink1073

Copy link
Copy Markdown
Contributor Author

Updated

@ellisonbg ellisonbg merged commit a49b65a into jupyterlab:master Jun 13, 2017
@yuvipanda

Copy link
Copy Markdown
Contributor

Hey what about us who use 3 spaces?

@yuvipanda

Copy link
Copy Markdown
Contributor

(just kidding, thank you for getting this in!)

@blink1073

Copy link
Copy Markdown
Contributor Author

\me throws shoe

@blink1073 blink1073 mentioned this pull request Jun 14, 2017
@blink1073 blink1073 deleted the fileeditor-settings branch July 10, 2017 17:56
@lock lock Bot added the status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion. label Aug 10, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement pkg:codemirror pkg:fileeditor status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion. tag:Feature Parity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No syntax highlighting for Dockerfile, Makefile, etc

3 participants