Skip to content

Bump lumino packages to 2.0.0-beta.0#13828

Merged
fcollonval merged 17 commits into
jupyterlab:masterfrom
krassowski:bump-lumino
Feb 9, 2023
Merged

Bump lumino packages to 2.0.0-beta.0#13828
fcollonval merged 17 commits into
jupyterlab:masterfrom
krassowski:bump-lumino

Conversation

@krassowski

@krassowski krassowski commented Jan 21, 2023

Copy link
Copy Markdown
Member

References

Needed for #13652 (and 4.0 release of course).

Corresponding lumino calver tag/changelog: v2023.1.13-beta.0.

Code changes

  • Bumps 2.0.0-alpha.62.0.0-beta.0
  • Re-aligns @lumino/datagrid version to 2.0.0-beta.0
    Initially we though we will release next @lumino/datagrid as 1.0, but it was changed in Audit DataGrid public API in preparation for 0.x => 2.0 lumino#458 without reflecting the changes on the lab side.
  • Update examples to include Signal.block() shims

Blockers:

@krassowski krassowski added this to the 4.0.0 milestone Jan 21, 2023
@jupyterlab-probot

Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval

Copy link
Copy Markdown
Member

Thanks @krassowski for all the fixes. I analyzed more deeply the error with the markdown cell and I think I get to the bottom of the code to blame in 7079293.

@krassowski

Copy link
Copy Markdown
Member Author

Thank you! We still see failures in js-cells and js-filebrowser; do you think that these are possibly related to the signal rework in lumino?

@fcollonval

Copy link
Copy Markdown
Member

Thank you! We still see failures in js-cells and js-filebrowser; do you think that these are possibly related to the signal rework in lumino?

I'll have a look tomorrow

@fcollonval fcollonval left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to go

@fcollonval

Copy link
Copy Markdown
Member

bot please update documentation snapshots

@github-actions

github-actions Bot commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

Documentation snapshots updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.