Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Theme switcher for more themes - #9396

Closed
elizavetaRa wants to merge 4 commits into
owncloud:masterfrom
cernbox:up_more-themes
Closed

Theme switcher for more themes#9396
elizavetaRa wants to merge 4 commits into
owncloud:masterfrom
cernbox:up_more-themes

Conversation

@elizavetaRa

@elizavetaRa elizavetaRa commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

Description

The pr adds the possibility to switch between themes when there are more than 2.

Related Issue

  • Fixes <issue_link>

Motivation and Context

Improving the accessibility by providing high contrast themes in addition to classical default and default dark

Screenshots (if appropriate):

Screenshot from 2023-07-12 12-17-20

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs

update-docs Bot commented Jul 12, 2023

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@elizavetaRa

Copy link
Copy Markdown
Contributor Author

@tbsbdr
To discuss:

  • icon (selected "paint", alternative: "paint-brush")
  • Need of heading (I personally like with it to clarify the purpose)
  • With heading looks better in card optic, without it could be done like roles menu

For further pr's: themes, theme names

@elizavetaRa elizavetaRa mentioned this pull request Jul 12, 2023
10 tasks
@pascalwengerter

Copy link
Copy Markdown
Contributor

Closing in favor of #9698, thanks for the initiative!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants