Skip to content

unpinned-tools, docs: fix typos - #2008

Merged
woodruffw merged 3 commits into
zizmorcore:mainfrom
martincostello:fix-typo
May 15, 2026
Merged

woodruffw merged 3 commits into
zizmorcore:mainfrom
martincostello:fix-typo

Conversation

@martincostello

@martincostello martincostello commented May 15, 2026 •

Copy link
Copy Markdown
Contributor

Pre-submission checks

Please check these boxes:

  • Mandatory: This PR corresponds to an issue (if not, please create
    one first).

  • Having read the AI policy, I hereby disclose the use of an LLM or other
    AI coding assistant in the creation of this PR. PRs will not be rejected
    for using AI tools, but will be rejected for undisclosed use or
    use that violates the policy.

If a checkbox is not applicable, you can leave it unchecked.

Summary

Fix typos found while reporting #2007 and #2009.

Test Plan

Visual inspection and updated the typo in the baselines.

Copilot AI review requested due to automatic review settings May 15, 2026 09:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Simple typo fix changing "implictly" to "implicitly" in the unpinned-tools audit finding message, with corresponding updates to test snapshot baselines.

Changes:

  • Fix typo in finding annotation message in unpinned_tools.rs
  • Update integration test baselines to match corrected spelling

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/zizmor/src/audit/unpinned_tools.rs Corrects "implictly" → "implicitly" in finding message
crates/zizmor/tests/integration/audit/unpinned_tools.rs Updates test baselines to reflect corrected spelling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@martincostello martincostello changed the title unpinned-tools: fix typo unpinned-tools: fix typos May 15, 2026
@martincostello martincostello changed the title unpinned-tools: fix typos unpinned-tools, docs: fix typos May 15, 2026
martincostello and others added 3 commits May 15, 2026 07:55
Fix typo in finding message.
Update `installaton` to `installation`.
@woodruffw

Copy link
Copy Markdown
Member

Thank you @martincostello!

@woodruffw woodruffw added the bugfix Fixes a known bug label May 15, 2026
@woodruffw

woodruffw commented May 15, 2026 •

Copy link
Copy Markdown
Member

P.S. in the future please don't request a review from Copilot, it sends me a lot of email notifications 🙂 (only one from each PR, but a lot in aggregate)

@woodruffw
woodruffw merged commit 53dea37 into zizmorcore:main May 15, 2026
16 checks passed
@martincostello

Copy link
Copy Markdown
Contributor Author

P.S. in the future please don't request a review from Copilot, it sends me a lot of email notifications 🙂 (only one from each PR, but a lot in aggregate)

I didn't explicitly ask Copilot to review for this specific PR, but I do have this Copilot setting enabled at my account level:

image

@martincostello
martincostello deleted the fix-typo branch May 15, 2026 15:07
@woodruffw

Copy link
Copy Markdown
Member

Ah, I'm kind of surprised that gets honored across third-party repos. I guess I'll see if there's a way I can disable it on the organization level here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a known bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants