Repository navigation
fix(unpinned-images): ignore empty matrix containers - #2102
Merged
Merged
Conversation
Ninja3047
force-pushed
the
fix-empty-matrix-container
branch
from
June 4, 2026 21:18
d9c9b90 to
779b355
Compare
woodruffw
approved these changes
Jun 4, 2026
woodruffw
left a comment
woodruffw
left a comment
Member
There was a problem hiding this comment.
Thanks @Ninja3047! Mind adding a line to the release notes as well?
Contributor
Author
|
updated |
Member
|
Thanks again @Ninja3047! In the future we might want to lift this into the matrix expansion iteration itself, i.e. skip empty expansions entirely. Not sure. Either way this seems great for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checks
Please check these boxes:
Mandatory: This PR corresponds to an issue (if not, please create
one first).
Having read the AI policy, I hereby disclose the use of an LLM or other
AI coding assistant in the creation of this PR. PRs will not be rejected
for using AI tools, but will be rejected for undisclosed use or
use that violates the policy.
If a checkbox is not applicable, you can leave it unchecked.
Summary
Fixes #2101 by skipping when the image itself is empty.
Test Plan
Tested regression test with and without the change. Also tested manually that the pedantic persona still catches the referenced container in the matrix.