Add asset id none check in dt - #45618
Merged
Pratibha Shrivastav (PratibhaShrivastav18) merged 4 commits intoMar 12, 2026
Merged
Conversation
Pratibha Shrivastav (PratibhaShrivastav18)
requested review from
Justin Firsching (JustinFirsching),
Klein Hu (NonStatic2014),
Amit Chauhan (achauhan-scc),
Arun (arunsu),
Jayesh Tanna (jayesh-tanna),
kingernupur,
Nikolay Rovinskiy (nick863),
Ayush Mishra (novaturient95),
raduk,
Razvan Tanase (rtanase),
Riti Sharma (sharma-riti) and
Vivek Ramaswamy (vivram)
as code owners
March 10, 2026 16:39
Copilot started reviewing on behalf of
Pratibha Shrivastav (PratibhaShrivastav18)
March 10, 2026 16:40
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure ML deployment default deployment template detection/logging to avoid reporting a template when the registry model’s default_deployment_template.asset_id is missing (None).
Changes:
- Tightened the
check_default_deployment_templatecondition to require a non-None/truthyasset_idbefore logging template details. - Minor import reordering/cleanup within
_endpoint_utils.py. - Added a corresponding bug-fix entry to the package changelog.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sdk/ml/azure-ai-ml/azure/ai/ml/_utils/_endpoint_utils.py |
Ensures default deployment template info is only logged when asset_id is present. |
sdk/ml/azure-ai-ml/CHANGELOG.md |
Documents the bug fix in the unreleased changelog. |
Kshitij Chawla (kshitij-microsoft)
approved these changes
Mar 12, 2026
Amit Chauhan (achauhan-scc)
approved these changes
Mar 12, 2026
Pratibha Shrivastav (PratibhaShrivastav18)
merged commit Mar 12, 2026
6074492
into
Azure:main
20 checks passed
Pratibha Shrivastav (PratibhaShrivastav18)
deleted the
shrivastavp/dt_bug_fixes
branch
March 12, 2026 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding asset id none check in deployment template to avoid wrong dt detections
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines