docs: fix TestClient examples and default client host - #3319
Merged
Conversation
A few issues in docs/testclient.md:
- The two `def test_app()` examples under "Selecting the Async backend"
are missing the trailing colon, so the snippets are not valid Python.
- The "Change client address" section says the default client host is
"testserver", but TestClient defaults `client` to ("testclient", 50000)
("testserver" is the base_url). request.client is ("testclient", 50000),
as asserted in tests/test_testclient.py. Update the docs to match.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
Re-trigger cubic
Kludex
approved these changes
Jun 5, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few issues in
docs/testclient.md:def test_app()examples under Selecting the Async backend are missing the trailing colon, so the snippets are not valid Python."testserver", butTestClientdefaultsclientto("testclient", 50000)("testserver"is thebase_url).request.clientis therefore("testclient", 50000), as asserted intests/test_testclient.py. The docs now say"testclient".Docs only — no behavior change.