Accept non-finite floats in check-yaml

[j178]

Closes #2544

[Copilot]

Pull request overview

Updates the check-yaml hook implementation to accept YAML non-finite float scalars (e.g., .nan, .inf) during decoding, aligning behavior with pre-commit-hooks and fixing issue #2544.

Changes:

• Configure serde_saphyr decoding options to allow non-finite typeless floats.
• Add a regression test covering .nan, .inf, and -.inf.
• Expand option comments with issue references for rationale and traceability.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.63%. Comparing base (6204a68) to head (5999d59).

Files with missing lines	Patch %	Lines
...ates/prek/src/hooks/pre_commit_hooks/check_yaml.rs	92.30%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2545   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files         134      134           
  Lines       28821    28834   +13     
=======================================
+ Hits        26986    26999   +13     
  Misses       1835     1835           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[prek-ci-bot]

📦 Cargo Bloat Comparison

Binary size change: +0.00% (30.2 MiB → 30.2 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.1%   2.2% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_encrypt_avx512
 1.1%   2.2% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_decrypt_avx512
 0.2%   0.5%  74.7KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  57.4KiB              prek prek::run::{closure#0}
 0.2%   0.4%  55.0KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.2%   0.3%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.1%   0.3%  40.7KiB              prek prek::cli::run::run::run::{closure#0}
 0.1%   0.3%  39.4KiB              prek <prek::languages::node::installer::NodeInstaller>::install::{closure#0}
 0.1%   0.2%  34.3KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  33.0KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
 0.1%   0.2%  30.5KiB     granit_parser <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
 0.1%   0.2%  28.6KiB    cargo_metadata <&mut serde_json::de::Deserializer<serde_json::read::StrRead> as serde_core::de::Deserializer>::deserialize_struct::<<cargo_metadata::Package as serde_core::de::Deserialize>::deserialize::__Visitor>
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB              prek <prek::languages::mise::installer::MiseInstaller>::download::{closure#0}
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble
 0.1%   0.2%  27.2KiB              prek <<prek::config::RemoteHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  26.5KiB              prek prek::cli::try_repo::try_repo::{closure#0}
 0.1%   0.2%  24.9KiB               xml <xml::reader::parser::PullParser>::dispatch_token
 0.1%   0.2%  24.2KiB              prek <<prek::config::LocalHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  23.5KiB              prek <<prek::config::UpdateOptions as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
42.8%  88.4%  12.9MiB                   And 26692 smaller methods. Use -n N to show more.
48.4% 100.0%  14.6MiB                   .text section size, the file size is 30.2MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.1%   2.2% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_encrypt_avx512
 1.1%   2.2% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_decrypt_avx512
 0.2%   0.5%  74.7KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  57.4KiB              prek prek::run::{closure#0}
 0.2%   0.4%  55.0KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.2%   0.3%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.1%   0.3%  40.7KiB              prek prek::cli::run::run::run::{closure#0}
 0.1%   0.3%  39.4KiB              prek <prek::languages::node::installer::NodeInstaller>::install::{closure#0}
 0.1%   0.2%  34.3KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  33.0KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
 0.1%   0.2%  30.5KiB     granit_parser <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
 0.1%   0.2%  28.6KiB    cargo_metadata <&mut serde_json::de::Deserializer<serde_json::read::StrRead> as serde_core::de::Deserializer>::deserialize_struct::<<cargo_metadata::Package as serde_core::de::Deserialize>::deserialize::__Visitor>
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB              prek <prek::languages::mise::installer::MiseInstaller>::download::{closure#0}
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble
 0.1%   0.2%  27.2KiB              prek <<prek::config::RemoteHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  26.5KiB              prek prek::cli::try_repo::try_repo::{closure#0}
 0.1%   0.2%  24.9KiB               xml <xml::reader::parser::PullParser>::dispatch_token
 0.1%   0.2%  24.2KiB              prek <<prek::config::LocalHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  23.5KiB              prek <<prek::config::UpdateOptions as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
42.8%  88.4%  12.9MiB                   And 26693 smaller methods. Use -n N to show more.
48.4% 100.0%  14.6MiB                   .text section size, the file size is 30.2MiB

[prek-ci-bot]

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

• OS: Linux 6.17.0-1020-azure
• CPU: 4 cores
• prek version: prek 0.4.13+2 (99151bd 2026-08-12)
• Rust version: rustc 1.97.1 (8bab26f4f 2026-07-14)
• Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base --version	2.5 ± 0.1	2.3	2.8	1.03 ± 0.06
prek-head --version	2.4 ± 0.1	2.3	3.3	1.00

prek list

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base list	10.5 ± 1.2	9.8	19.0	1.02 ± 0.12
prek-head list	10.2 ± 0.2	9.8	11.1	1.00

prek validate-config .pre-commit-config.yaml

⏭️ Skipped: .pre-commit-config.yaml not found

prek sample-config

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base sample-config	2.8 ± 0.1	2.6	2.9	1.00 ± 0.03
prek-head sample-config	2.7 ± 0.0	2.6	2.8	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	41.1 ± 1.0	39.8	43.3	1.01 ± 0.04
prek-head run --all-files	40.6 ± 1.3	37.9	42.3	1.00

prek run --all-files (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	40.2 ± 1.7	38.0	45.1	1.00
prek-head run --all-files	40.5 ± 1.4	36.9	43.5	1.01 ± 0.06

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	41.0 ± 1.0	38.4	43.1	1.01 ± 0.04
prek-head run --all-files	40.4 ± 1.2	38.0	42.9	1.00

Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run trailing-whitespace --all-files	14.5 ± 0.4	13.8	15.6	1.01 ± 0.04
prek-head run trailing-whitespace --all-files	14.4 ± 0.4	13.6	15.2	1.00

prek run end-of-file-fixer --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run end-of-file-fixer --all-files	13.3 ± 1.5	12.0	20.5	1.03 ± 0.12
prek-head run end-of-file-fixer --all-files	13.0 ± 0.5	12.1	13.9	1.00

prek run check-json --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-json --all-files	9.4 ± 0.2	8.9	9.8	1.00
prek-head run check-json --all-files	9.6 ± 0.6	8.6	11.9	1.03 ± 0.07

prek run check-yaml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-yaml --all-files	9.1 ± 0.3	8.6	9.7	1.00
prek-head run check-yaml --all-files	9.2 ± 0.3	8.6	10.0	1.00 ± 0.05

prek run check-toml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-toml --all-files	9.3 ± 0.6	8.7	12.2	1.00
prek-head run check-toml --all-files	9.4 ± 0.4	8.7	10.2	1.02 ± 0.08

prek run check-xml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-xml --all-files	9.4 ± 0.5	8.4	10.3	1.02 ± 0.06
prek-head run check-xml --all-files	9.2 ± 0.3	8.8	10.1	1.00

prek run detect-private-key --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run detect-private-key --all-files	12.5 ± 0.5	11.8	13.6	1.00
prek-head run detect-private-key --all-files	12.8 ± 0.6	11.4	14.4	1.02 ± 0.07

prek run fix-byte-order-marker --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run fix-byte-order-marker --all-files	14.2 ± 0.7	13.3	16.0	1.00
prek-head run fix-byte-order-marker --all-files	14.6 ± 0.7	13.2	15.7	1.02 ± 0.07

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	5.6 ± 0.1	5.5	5.8	1.01 ± 0.03
prek-head install-hooks	5.6 ± 0.2	5.4	5.8	1.00

prek install-hooks (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	5.3 ± 0.0	5.3	5.4	1.00
prek-head install-hooks	5.5 ± 0.1	5.4	5.6	1.03 ± 0.01

File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run	28.0 ± 1.0	26.5	29.9	1.01 ± 0.05
prek-head run	27.7 ± 0.8	26.4	29.2	1.00

prek run --files '*.json' (specific file type)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --files '*.json'	6.8 ± 0.1	6.5	6.9	1.04 ± 0.04
prek-head run --files '*.json'	6.5 ± 0.2	6.1	6.9	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --dry-run --all-files	8.7 ± 0.3	8.2	9.3	1.01 ± 0.04
prek-head run --dry-run --all-files	8.6 ± 0.2	8.2	8.9	1.00

Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-hooks-apply --all-files	9.9 ± 0.2	9.4	10.4	1.00
prek-head run check-hooks-apply --all-files	10.2 ± 0.2	9.8	10.6	1.03 ± 0.03

prek run check-useless-excludes --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-useless-excludes --all-files	9.9 ± 0.2	9.6	10.3	1.01 ± 0.03
prek-head run check-useless-excludes --all-files	9.8 ± 0.3	9.4	10.4	1.00

prek run identity --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run identity --all-files	8.8 ± 0.3	8.4	9.3	1.00
prek-head run identity --all-files	8.9 ± 0.1	8.6	9.2	1.02 ± 0.03