feat(linter): add schema for react/jsx-handler-names (#23393)

Adds verified config schema generation for `react/jsx-handler-names`.

Refs #22955.

Author: WaterWhisperer

apps/oxlint/src-js/package/config.generated.ts

@@ -1300,7 +1300,7 @@ export interface DummyRuleMap {
   "react/jsx-curly-brace-presence"?: DummyRule;
   "react/jsx-filename-extension"?: AllowWarnDeny | [AllowWarnDeny] | [AllowWarnDeny, JsxFilenameExtensionConfig];
   "react/jsx-fragments"?: AllowWarnDeny | [AllowWarnDeny] | [AllowWarnDeny, FragmentMode];
-  "react/jsx-handler-names"?: DummyRule;
+  "react/jsx-handler-names"?: AllowWarnDeny | [AllowWarnDeny] | [AllowWarnDeny, JsxHandlerNamesConfig];
   "react/jsx-key"?: AllowWarnDeny | [AllowWarnDeny] | [AllowWarnDeny, JsxKeyConfig];
   "react/jsx-max-depth"?: AllowWarnDeny | [AllowWarnDeny] | [AllowWarnDeny, JsxMaxDepthConfig];
   "react/jsx-no-comment-textnodes"?: RuleNoConfig;
@@ -4386,6 +4386,28 @@ export interface JsxFilenameExtensionConfig {
    */
   ignoreFilesWithoutCode?: boolean;
 }
+export interface JsxHandlerNamesConfig {
+  /**
+   * Whether to check for inline functions in JSX attributes.
+   */
+  checkInlineFunction?: boolean;
+  /**
+   * Whether to check for local variables in JSX attributes.
+   */
+  checkLocalVariables?: boolean;
+  /**
+   * Event handler prefixes to check against.
+   */
+  eventHandlerPrefix?: string | false;
+  /**
+   * Event handler prop prefixes to check against.
+   */
+  eventHandlerPropPrefix?: string | false;
+  /**
+   * Component names to ignore when checking for event handler prefixes.
+   */
+  ignoreComponentNames?: string[];
+}
 export interface JsxKeyConfig {
   /**
    * When true, check fragment shorthand `<>` for keys

crates/oxc_linter/src/rules/react/jsx_handler_names.rs

@@ -12,7 +12,10 @@ use oxc_diagnostics::OxcDiagnostic;
 use oxc_macros::declare_oxc_lint;
 use oxc_span::Span;
 use oxc_str::CompactStr;
-use schemars::JsonSchema;
+use schemars::{
+    JsonSchema, SchemaGenerator,
+    schema::{Schema, SchemaObject, SubschemaValidation},
+};
 use serde_json::Value;
 
 fn bad_handler_name_diagnostic(
@@ -53,24 +56,58 @@ fn bad_handler_prop_name_diagnostic(
 pub struct JsxHandlerNames(Box<JsxHandlerNamesConfig>);
 
 #[derive(Debug, Clone, JsonSchema)]
-#[serde(rename_all = "camelCase", default)]
+#[serde(rename_all = "camelCase", default, deny_unknown_fields)]
 pub struct JsxHandlerNamesConfig {
     /// Whether to check for inline functions in JSX attributes.
+    #[serde(rename = "checkInlineFunction")]
     check_inline_functions: bool,
     /// Whether to check for local variables in JSX attributes.
     check_local_variables: bool,
     /// Event handler prop prefixes to check against.
+    #[serde(rename = "eventHandlerPropPrefix")]
+    #[schemars(with = "HandlerPrefix")]
     event_handler_prop_prefixes: CompactStr,
     /// Event handler prefixes to check against.
+    #[serde(rename = "eventHandlerPrefix")]
+    #[schemars(with = "HandlerPrefix")]
     event_handler_prefixes: CompactStr,
     /// Component names to ignore when checking for event handler prefixes.
     ignore_component_names: Vec<CompactStr>,
     /// Compiled regex for event handler prefixes.
+    #[schemars(skip)]
     event_handler_regex: Option<Regex>,
     /// Compiled regex for event handler prop prefixes.
+    #[schemars(skip)]
     event_handler_prop_regex: Option<Regex>,
 }
 
+#[derive(Debug)]
+struct HandlerPrefix;
+
+impl JsonSchema for HandlerPrefix {
+    fn schema_name() -> String {
+        "HandlerPrefix".to_string()
+    }
+
+    fn json_schema(r#gen: &mut SchemaGenerator) -> Schema {
+        let mut false_schema = <bool as JsonSchema>::json_schema(r#gen).into_object();
+        false_schema.const_value = Some(serde_json::Value::Bool(false));
+
+        SchemaObject {
+            subschemas: Some(Box::new(SubschemaValidation {
+                any_of: Some(vec![<String as JsonSchema>::json_schema(r#gen), false_schema.into()]),
+                ..Default::default()
+            })),
+            ..Default::default()
+        }
+        .into()
+    }
+
+    fn is_referenceable() -> bool {
+        false
+    }
+}
+
 impl std::ops::Deref for JsxHandlerNames {
     type Target = JsxHandlerNamesConfig;
 

crates/oxc_linter/src/utils/schemars.rs

@@ -13,7 +13,7 @@ use crate::rules::RuleEnum;
 /// These should return the DummyRule struct/schema instead of the actual rule struct/schema,
 /// until we verify that the rule's schema is valid and can be generated by schemars.
 #[cfg(feature = "ruledocs")]
-const NO_VERIFIED_VALID_SCHEMA: [&str; 19] = [
+const NO_VERIFIED_VALID_SCHEMA: [&str; 18] = [
     "eslint/func-name-matching", // second config can be on first position like [AllowWarnDeny, Config1, Config2] | [AllowWarnDeny, Config1] | [AllowWarnDeny, Config2]
     "eslint/no-restricted-globals", // uses spread syntax like [AllowWarnDeny, ...Config]
     "eslint/no-restricted-imports", // uses spread syntax like [AllowWarnDeny, ...Config]
@@ -31,7 +31,6 @@ const NO_VERIFIED_VALID_SCHEMA: [&str; 19] = [
     "jsx_a11y/no-noninteractive-element-interactions", // TS Generation generates ts 2411 error
     "eslint/prefer-destructuring",
     "react/jsx-curly-brace-presence",
-    "react/jsx-handler-names",
     "react/jsx-no-script-url",
 ];
 

npm/oxlint/configuration_schema.json

@@ -6254,7 +6254,24 @@
           ]
         },
         "react/jsx-handler-names": {
-          "$ref": "#/definitions/DummyRule"
+          "anyOf": [
+            {
+              "$ref": "#/definitions/AllowWarnDeny"
+            },
+            {
+              "type": "array",
+              "items": [
+                {
+                  "$ref": "#/definitions/AllowWarnDeny"
+                },
+                {
+                  "$ref": "#/definitions/JsxHandlerNamesConfig"
+                }
+              ],
+              "maxItems": 2,
+              "minItems": 1
+            }
+          ]
         },
         "react/jsx-key": {
           "anyOf": [
@@ -11309,6 +11326,61 @@
       },
       "additionalProperties": false
     },
+    "JsxHandlerNamesConfig": {
+      "type": "object",
+      "properties": {
+        "checkInlineFunction": {
+          "description": "Whether to check for inline functions in JSX attributes.",
+          "default": false,
+          "type": "boolean",
+          "markdownDescription": "Whether to check for inline functions in JSX attributes."
+        },
+        "checkLocalVariables": {
+          "description": "Whether to check for local variables in JSX attributes.",
+          "default": false,
+          "type": "boolean",
+          "markdownDescription": "Whether to check for local variables in JSX attributes."
+        },
+        "eventHandlerPrefix": {
+          "description": "Event handler prefixes to check against.",
+          "default": "handle",
+          "anyOf": [
+            {
+              "type": "string"
+            },
+            {
+              "type": "boolean",
+              "const": false
+            }
+          ],
+          "markdownDescription": "Event handler prefixes to check against."
+        },
+        "eventHandlerPropPrefix": {
+          "description": "Event handler prop prefixes to check against.",
+          "default": "on",
+          "anyOf": [
+            {
+              "type": "string"
+            },
+            {
+              "type": "boolean",
+              "const": false
+            }
+          ],
+          "markdownDescription": "Event handler prop prefixes to check against."
+        },
+        "ignoreComponentNames": {
+          "description": "Component names to ignore when checking for event handler prefixes.",
+          "default": [],
+          "type": "array",
+          "items": {
+            "type": "string"
+          },
+          "markdownDescription": "Component names to ignore when checking for event handler prefixes."
+        }
+      },
+      "additionalProperties": false
+    },
     "JsxKeyConfig": {
       "type": "object",
       "properties": {