Skip to content

@types/react-dom marked as unused, despite being requested as a peer dependency #239

Description

@alecmev

Reproduction: https://github.com/alecmev/knip-repro-239 I thought about this for a bit, trying to figure out if it's Babylon.js' fault, but I don't think it is? They just want to pin the version, so that we don't run into any mismatch issues. I also don't think this is #220, unless there's a bug?

Activity

  1. changed the title [-]`@types/react-dom` marked as an unused dependency, despite being requested as a peer dependency[/-] [+]`@types/react-dom` marked as unused, despite being requested as a peer dependency[/+] on Sep 14, 2023
  2. webpro commented on Sep 18, 2023

    @webpro
    Member

    🚀 This issue has been resolved in v2.25.1. See Release 2.25.1 for release notes.

  3. webpro commented on Sep 18, 2023

    @webpro
    Member

    Agreed :)

  4. alecmev commented on Sep 18, 2023

    @alecmev
    Author

    Thank you! 👌

  5. added a commit that references this issue on May 12, 2024
    ef94f5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions