Message153671
Iâve had a look at your implementation. It is an interesting use of properties, but doesnât quite fit into how packaging works. Most of the options parsing and validation (from config files and command-line alike) is done in each commandâs finalize_options method, some parsing and validation is done in the config module (for the metadata, files and soon extension sections), and the section named âglobalâ is validated by the Distribution (or maybe Dispatcher now) class. So Iâll certainly reuse your tests, but will have to redo the implementation.
Iâm also wondering if install_dataâs options are the right place for this. For example, does it make sense to allow âpysetup run install_data --categories spam=blahâ? (Any command option can be given on the command line.) Maybe the global section of setup.cfg would be better. |
|
| Date |
User |
Action |
Args |
| 2012-02-19 06:20:34 | eric.araujo | set | recipients:
+ eric.araujo, vinay.sajip, tarek, alexis |
| 2012-02-19 06:20:34 | eric.araujo | set | messageid: <1329632434.39.0.0734457312276.issue12393@psf.upfronthosting.co.za> |
| 2012-02-19 06:20:33 | eric.araujo | link | issue12393 messages |
| 2012-02-19 06:20:32 | eric.araujo | create | |
|