Looks ok to me.
-phil.
On 12/28/2010 3:19 PM, Kelly O'Hair wrote:
> Need Reviewer: Windows VS2010 warning silencing
>> With Windows VS2010 compilers, we started seeing many warnings about
> supposedly insecure function usage.
> These are not actually detecting errors as much as indicating that
> certain functions used have been known to
> cause security issues when used improperly, so all uses will create a
> warning error.
>> As much as I agree that some of these functions should not be used
> (sprintf,...), I don't entirely agree with some
> of these warnings, especially when the supposedly insecure function is
> used safely.
> The change below should silence the bulk of these warnings, allowing
> us to see the more critical warnings that
> we really need to fix, not sure what the future setting will be for this.
>> Expect some efforts in the coming months to reduce warnings, and also
> reduce the use of selected 'banned functions'.
>> 6991482: Add global jdk makefile options to silence some VS2010 warnings
>http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-WIN_WARN/webrev/>> -kto
>> P.S. For more on the Windows Banned functions, see:
>http://msdn.microsoft.com/en-us/library/bb288454.aspx>
