Chore: Update eslint and its config, clean up some lint#3293
Merged
Conversation
roundhill
approved these changes
Feb 12, 2025
roundhill
left a comment
roundhill
left a comment
Contributor
There was a problem hiding this comment.
Tested well, I noticed this error in the logs while searching:
Tooltip.js:315 MUI: You are providing a disabled `button` child to the Tooltip component.
A disabled element does not fire events.
Tooltip needs to listen to the child element's events to display the title.
Add a simple wrapper element, such as a `span`.
codebykat
force-pushed
the
update/eslint
branch
from
c6f89bc to
a5cc4d5
Compare
Contributor
Author
|
Oh hm that looks familiar. I wonder if I had a solution to it in the past... |
…e is in agreement
codebykat
force-pushed
the
update/eslint
branch
from
a5cc4d5 to
2ac6e48
Compare
Contributor
Author
|
Circled back to this and fixed up the MUI warning. ref: mui/material-ui#8416 Could use another 👀 since I rebased it. |
roundhill
approved these changes
Feb 28, 2025
roundhill
left a comment
roundhill
left a comment
Contributor
There was a problem hiding this comment.
Still tested well after latest changes 👍
Contributor
|
💙 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Spun this off from the other dependencies upgrade so we can lint things in peace. eslint 9 moved to a new config file format.
See https://eslint.org/docs/latest/use/configure/migration-guide
incl. a small fix for a MUI console warning about tooltips on disabled buttons.
Test
make lintMine shows:
✖ 31 problems (0 errors, 31 warnings)Release
RELEASE-NOTES.mdwas updated with: