[Base64 Image] Click on save or view while no input made the app crashing

[veler]

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• UI change (please include screenshot!)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Internationalization and localization
• Other (please describe):

What is the current behavior?

Issue Number: #526

What is the new behavior?

The buttons are now hidden if there's no image visible.

Quality check

Before creating this PR, have you:

• Followed the code style guideline as described in CONTRIBUTING.md
• Verified that the change work in Release build configuration
• Checked all unit tests pass

[btiteux]

Hello,

I just tested the pull request, there is no button if no image that's good.

But I tried with a picture (around 578Kb) the picture is converted to base64, but then I can't do anything.

I had to wait almost two minutes to get a reaction from the tools an idea to avoid that?

[veler]

Hello,

I just tested the pull request, there is no button if no image that's good.

But I tried with a picture (around 578Kb) the picture is converted to base64, but then I can't do anything.

I had to wait almost two minutes to get a reaction from the tools an idea to avoid that?

Yup. It's a totally unrelated issue. The problem here is the UWP TextBox. It doesn't handle well very long text that doesn't have any whitespace :'(
Best alternative I can think about is using the Monaco editor, but it sounds a bit overkill too, and not ideal at the end of the day. What do you think?

[veler]

Following private conversation => we will use Monaco editor and will address it in another PR.