Skip to content

MAS doesn't seem to use KSPAssembly attribute #354

Description

@JonnyOThan

I'm working on adding MAS support to KerbalVR, and the way this works is that I have bridge dlls that can talk directly to RPM and MAS. The RPM one uses a KSPAssemblyDependency attribute to tell KSP to not load it if RPM is not present. I was going to do the same with MAS, but it doesn't seem to have a KSPAssembly attribute that I can use to target it.

Activity

  1. JonnyOThan commented on Oct 1, 2022

    @JonnyOThan
    CollaboratorAuthor

    I’m happy to send a pr for this, but it’s a little tricky because of the shared assembly info file. The other project that uses it doesn’t depend on the KSP dll. Possible solutions:

    1. abandon the shared assembly info file. You’d need to manually keep the version numbers in sync (if that’s actually important)
    2. put the KSPAssembly attribute into the non-shared assembly info file. You’d need to update the version numbers in two places.
    3. Something more complicated using text templating to generate all the files so the version number can be set in a single place
    4. add a dependency on assembly-csharp to the other project

    I’d opt for 1, but I’ll leave it up to you

  2. self-assigned this
    on Oct 1, 2022
  3. MOARdV commented on Oct 1, 2022

    @MOARdV
    Collaborator

    Yeah, separating the assembly file is the route I'd take. I'm not really distributing the config generator tool now, and it's not getting updated regularly, so it doesn't need synchronized version numbers.

  4. added this to the v1.3.6 milestone on Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions