Revert "Merge pull request #767 from Morganamilo/merge-dep-pool-order"#866
Merged
Conversation
Owner
|
I'm also in the same situation but I'll take the revert until this is sorted. I'm merging this, counseling every open thread to retry using this version and then we'll go from there |
Contributor
Author
|
I'm all for a release now. There's not too much going on right now and this fix is pretty important. |
Owner
|
Let's go for it then |
This was referenced Jan 26, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c2aeb4b, reversing
changes made to 1f1cee7.
This should fix the ton of recent issues which I assume are because of the depsolver changes. This will bring back the inner conflicts issues that prevent some circular dependencies from resolving. But they are rare enough compared to the ton of open issues right now.
Due to lack of time I'm just reverting the code, if I have time in future (or some one else wants to take on the task) then the code can be fixed and merged back in.