Repository navigation
Install meta tester at system level again - #3968
Merged
Merged
Conversation
HebaruSan
added
Bug
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The meta tester is broken.
Cause
In #3958 I added
--userto thepip3 install, because I thought it would be cleaner than copying/usr/localfrom one image to the next. However, when it runs these images, GitHub sets$HOMEto/github/home, which they map to a folder they control:This takes
/root/.local/lib/python3.10, which is where all our modules are installed, out of Python's module search path, which breaks everything. (It also makes for a very confusing problem because mydocker runcommands seemed to work fine until I spottedHOMEin that long list of environment variables.)Changes
Now we install to
/usr/localagain and copy it forward. Impact on image size is negligible: