Repository navigation
Only hard link existing files if file sizes match - #4453
Merged
HebaruSan merged 6 commits intoOct 22, 2025
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Both @linuxgurugamer and @JonnyOThan have reported this.
CKAN/GUIConfig.jsonandCKAN/GUIConfig.xmlare missing, aFileNotFoundexception is thrown when opening the game instance (also dev build only).Reported by @Clayell on Discord.
Causes
InstalledFilesDeduplicatoruses the mod identifier, version, and file relative path to uniquely identify files that might be duplicates. Since overwriting a file doesn't change any of these, an overwritten file is considered the same as the original and can be hard linked instead of extracted when installing the same file in another instance.GUIConfiguration.LoadXMLhandles exceptions for parsing the file, but not for when it doesn't exist.Changes
InstalledFilesDeduplicatoruses the mod identifier, version, file relative path, and file size to uniquely identify files that might be duplicates. This way, if the file size doesn't match what's in the original ZIP, we conclude that it has been overwritten and won't create a hard link to it.File size is not a perfect way to detect changed files, but it is extremely low-cost to calculate compared to hashing, and different files are unlikely to have the same size when they're generaed by a paint program or a compiler.
Fixes Manual overwrites of hard linkable files installed by CKAN can create hard links to the overwritten files #4451.
CKAN/GUIConfig.jsonandCKAN/GUIConfig.xmlare missing,GUIConfiguration.LoadXMLcatches the exception and returnsnullso we can fall back to a new config object.