Skip to content

Catch forbidden GUI calls via Util.Debounce - #4492

Merged
HebaruSan merged 3 commits into
KSP-CKAN:masterfrom
HebaruSan:add/gui-debounce-tests
Jan 11, 2026
Merged

HebaruSan merged 3 commits into
KSP-CKAN:masterfrom
HebaruSan:add/gui-debounce-tests

Conversation

@HebaruSan

Copy link
Copy Markdown
Member

Motivation

The problem fixed in #4491 should have a test to catch regressions.

Changes

  • The GUI threading test from Add test to check GUI thread safety #3914 now checks the arguments of Util.Debounce for forbidden GUI calls.
  • A potentially problematic GUI call caught by the test in EditModSearch is now called on the GUI thread via Util.Invoke.

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Tests Issues affecting the internal tests labels Jan 11, 2026
@HebaruSan
HebaruSan merged commit 8e5bf58 into KSP-CKAN:master Jan 11, 2026
9 of 10 checks passed
@HebaruSan
HebaruSan deleted the add/gui-debounce-tests branch January 11, 2026 19:02
@coveralls

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New features or functionality GUI Issues affecting the interactive GUI Tests Issues affecting the internal tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants