Repository navigation
Fix item with the same key exception - #4569
Merged
Merged
Conversation
Coverage Report for CI Build 24478773103Coverage remained the same at 85.549%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Artemis II KSP revival continues to summon new and interesting problems to the Discord:
Reported by Discord user JLSkyzer.
Cause
The user had installed both KOSHUD and kOS-Computer on Windows using a version of CKAN older than #3479, so their
registry.json'sinstalled_filesobject contained both of these:These represent the same folder on Windows, so when we load that registry, newer versions of CKAN use
Platform.PathComparerto coalesce them into one entry. Unfortunately that causes an exception to be thrown.Changes
Now we filter out duplicate keys before we make the dictionary.