Repository navigation
[SkipRecovery] Re-enable mixed-delete tests on Iceberg 1.10.2+ [reduced-it] [databricks] - #15964
Merged
Merged
Conversation
Signed-off-by: Allen Xu <allxu@nvidia.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Re-enables mixed Iceberg delete validation for Iceberg 1.11+ while preserving quarantine behavior for older or unknown versions.
Changes:
- Gates xfail and fixed-seed markers by Iceberg version.
- Disables AQE for the v3 count-plan assertion.
- Resets Spark configuration before cleanup.
File summaries
| File | Description |
|---|---|
integration_tests/src/main/python/iceberg/iceberg_merge_on_read_test.py |
Updates mixed-delete test gating and session cleanup. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Collaborator
Author
|
build |
firestarman
reviewed
Sep 11, 2026
Signed-off-by: Allen Xu <allxu@nvidia.com>
Collaborator
Author
|
build |
firestarman
previously approved these changes
Sep 11, 2026
Collaborator
Author
|
build |
Signed-off-by: Allen Xu <allxu@nvidia.com>
Collaborator
Author
|
build |
Signed-off-by: Allen Xu <allxu@nvidia.com>
Signed-off-by: Allen Xu <allxu@nvidia.com>
liurenjie1024
approved these changes
Sep 14, 2026
Collaborator
Author
|
build |
NvTimLiu
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JaCoCo production line coverage: not fully measurable locally — no compatible Scala 2.13 / shim 411 nightly baseline is published.
Contributes to #12885.
Description
This test-only recovery restores enforced CPU/GPU result checks for mixed Iceberg position and equality deletes on Iceberg 1.10.2 and newer. Before this change, the format-v2 and format-v3 cases were permanent expected failures with fixed data seeds even on runtimes containing the upstream equality-delete cache fix. The affected older releases are now skipped instead of spending test time on known failures; production behavior is unchanged.
Apache Iceberg #15514, released in 1.11.0 and backported to 1.10.2, fixes equality-delete records being cached in a query-dependent field order. This PR:
--iceberglacks an expected runtime version.Older supported dependencies are not fixed by this PR, so #12885 should remain open. Iceberg 1.10.2 was policy-checked but was not GPU-runtime-tested locally. Shared pytest configuration and pre-merge launcher paths changed, so Databricks remains in CI scope.
Validation
6 passed, 45 deselectedin 219.85 seconds). Full-row equality and the format-v3GpuBatchScanExecassertion were exercised.6 skipped, 45 deselectedin 1.73 seconds).EXPECTED_ICEBERG_VERSIONwith--icebergfailed during pytest configuration with exit 4 and the expected error.bash -nand a focused launcher probe confirmed that the Spark 4.0 extra-classpath path forwards Iceberg 1.10.1.git diff --checkpassed.No production performance change is expected.
AI assistance: The change and PR description were prepared with Codex assistance.
Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance