Fix site handing after enabling user time zone feature

[hishamco]

Fix #17069

[MikeAlhayek]

@hishamco the actual fix here is not to resolve UserManager<IUser> or UserStore in UserTimeZoneService. Have a look at PR #17073

[hishamco]

@hishamco the actual fix here is not to resolve UserManager or UserStore in UserTimeZoneService

Did you try the PR? I already tested

[MikeAlhayek]

Did you try the PR? I already tested

Yes. The reason why you PR works, is because you no longer resolve UserManager<> from the handler which is causing the circular dependency. So if instead of injecting UserManager<> to get user name, get the user using ISession this way we can keep the cache centralized in one place. settings the cache in one place and then invalid it using another service is not a good idea from maintenance perspective.

[hishamco]

Nothing but I saw the you mix both the service & the handler which is against the standard

[MikeAlhayek]

Nothing but I saw the you mix both the service & the handler which is against the standard

@hishamco

From design, what we have is perfectly fine. I am okay with this PR as long as you expose GetCacheKey internally and use the same method in both classes.

[MikeAlhayek]

/backport to release/2.1

[github-actions]

Started backporting to release/2.1: https://github.com/OrchardCMS/OrchardCore/actions/runs/12037243179