Repository navigation
Remove ReCaptchaMode and DetectionThreshold - #17229
Merged
Merged
Conversation
Member
Author
|
@rjpowers10 I have to update docs and release notes. But, can you please test this out? The expected behavior is that if the reCapcha feature is enabled, then will always present the challenge. We no longer have threshold. If the user tried multiple times their account will get locked after 5 tries by default during login. I think if we ever use v3 of Google, then the challenge is handled differently but either way we won't need to worry about doing threshold ourselves. |
Member
Author
|
@rjpowers10 were you able to test this out? |
Contributor
|
@MikeAlhayek I took a quick look and the ReCaptcha displayed in all four locations as expected.
|
Member
Author
|
Thanks for confirming. |
This was referenced Jan 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #17200