Skip to content

Remove ReCaptchaMode and DetectionThreshold - #17229

Merged
MikeAlhayek merged 7 commits into
mainfrom
ma/rechapcha-remove-mode
Dec 17, 2024
Merged

MikeAlhayek merged 7 commits into
mainfrom
ma/rechapcha-remove-mode

Conversation

@MikeAlhayek

@MikeAlhayek MikeAlhayek commented Dec 12, 2024 •

Copy link
Copy Markdown
Member

Fix #17200

@MikeAlhayek

Copy link
Copy Markdown
Member Author

@rjpowers10 I have to update docs and release notes. But, can you please test this out?

The expected behavior is that if the reCapcha feature is enabled, then will always present the challenge. We no longer have threshold.

If the user tried multiple times their account will get locked after 5 tries by default during login.

I think if we ever use v3 of Google, then the challenge is handled differently but either way we won't need to worry about doing threshold ourselves.

@MikeAlhayek

Copy link
Copy Markdown
Member Author

@rjpowers10 were you able to test this out?

@rjpowers10

Copy link
Copy Markdown
Contributor

@MikeAlhayek I took a quick look and the ReCaptcha displayed in all four locations as expected.

  1. Login page
  2. Registration page
  3. Forgot password page
  4. Reset password page

@MikeAlhayek

Copy link
Copy Markdown
Member Author

Thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReCaptchaSettings.DetectionThreshold is not counted correctly for log in

2 participants