Repository navigation
fix(mcp): use CodeBuddy project configuration path - #482
Merged
Merged
Conversation
Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeBuddy Code reads project MCP configuration from the project root's
.mcp.json, while TeamAI's default points at.codebuddy/mcp.json. Correct the default project path and document migration for teams with an explicit old path. User-scope targets, WorkBuddy and explicit team overrides retain their existing behavior.The path is verified against the official CodeBuddy MCP documentation. It lists
.mcp.json, then rootmcp.json, for PROJECT scope; the tool subdirectory is not a project fallback.Type of Change
Test Plan
b4150c74435e1c28288d3938db23f771f55d8164: Node 20/22 on Ubuntu/macOS, including type checks and the full unit suite with coverage.mcp list,mcp inject, repeated injection andmcp remove; verifies the root configuration, personal-server preservation, idempotency and unchanged user-scope data.git diff --checkpassed.The fork validation commit
7d8cbf3dd2cd30c3256af49225d1388202b81e30directly follows the contribution head. Its only additional change is the existing CI push branch filter; source, tests, jobs, permissions and release workflow are unchanged by that validation commit.The separate GitHub-provider full-surface E2E job was skipped in both runs; it is not included in the passing E2E coverage above. The fork has no configured fixture repository variable. The built-CLI scenario validates configuration delivery without calling a real MCP service or paid model API. Tencent CodeCC also passed on the current contribution head.
Related Issues
Fixes #474
Notes for Reviewers
Existing explicit
toolPaths.codebuddy.mcpProjectvalues are respected. The bilingual guides explain removal/reinjection when changing the old value; this patch does not move or delete existing configuration files. Claude Code and CodeBuddy share the root.mcp.jsonby their own configuration conventions.